Andrey/uptime-kuma
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Adjust defaults for error response save

Browse Source
This commit is contained in:
codercms 2026-01-12 16:03:35 +03:00
parent ad6603cd03
commit 7a7a062da8
3 changed files with 32 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
db/knex_migrations/2025-10-15-0001-add-monitor-response-config.js
View File

@ -1,7 +1,7 @@
exports.up = function (knex) {
return knex.schema.alterTable("monitor", function (table) {
table.boolean("save_response").notNullable().defaultTo(false);
table.boolean("save_error_response").notNullable().defaultTo(false);
table.boolean("save_error_response").notNullable().defaultTo(true);
table.integer("response_max_length").defaultTo(10240); // Default 10KB
});
};

30
src/pages/EditMonitor.vue
View File

@ -1496,7 +1496,14 @@
</div>
</div>
<div class="my-3">
<div
v-if="
monitor.type === 'http' ||
monitor.type === 'keyword' ||
monitor.type === 'json-query'
"
class="my-3"
>
<div class="form-check">
<input
id="saveResponse"
@ -1517,7 +1524,14 @@
</div>
</div>
<div class="my-3">
<div
v-if="
monitor.type === 'http' ||
monitor.type === 'keyword' ||
monitor.type === 'json-query'
"
class="my-3"
>
<div class="form-check">
<input
id="saveErrorResponse"
@ -1538,7 +1552,15 @@
</div>
</div>
<div v-if="monitor.saveResponse || monitor.saveErrorResponse" class="my-3">
<div
v-if="
(monitor.type === 'http' ||
monitor.type === 'keyword' ||
monitor.type === 'json-query') &&
(monitor.saveResponse || monitor.saveErrorResponse)
"
class="my-3"
>
<label for="responseMaxLength" class="form-label">
{{ $t("responseMaxLength") }}
</label>
@ -2226,7 +2248,7 @@ const monitorDefaults = {
maxredirects: 10,
accepted_statuscodes: ["200-299"],
saveResponse: false,
saveErrorResponse: false,
saveErrorResponse: true,
responseMaxLength: 10240,
dns_resolve_type: "A",
dns_resolve_server: "1.1.1.1",

7
test/e2e/specs/monitor-form.spec.js
View File

@ -115,8 +115,11 @@ test.describe("Monitor Form", () => {
await page.getByTestId("friendly-name-input").fill(friendlyName);
await page.getByTestId("url-input").fill("https://www.example.com/");
// Expect error response save enabled by default
await expect(page.getByLabel("Save HTTP Error Response for Notifications")).toBeChecked();
await page.getByLabel("Save HTTP Success Response for Notifications").check();
await page.getByLabel("Save HTTP Error Response for Notifications").check();
await page.getByLabel("Save HTTP Error Response for Notifications").uncheck();
await page.getByLabel("Response Max Length (bytes)").fill("2048");
await screenshot(testInfo, page);
@ -127,7 +130,7 @@ test.describe("Monitor Form", () => {
await page.waitForURL("/edit/*");
await expect(page.getByLabel("Save HTTP Success Response for Notifications")).toBeChecked();
await expect(page.getByLabel("Save HTTP Error Response for Notifications")).toBeChecked();
await expect(page.getByLabel("Save HTTP Error Response for Notifications")).toBeChecked({ checked: false });
await expect(page.getByLabel("Response Max Length (bytes)")).toHaveValue("2048");
await screenshot(testInfo, page);