diff --git a/db/knex_migrations/2025-10-15-0001-add-monitor-response-config.js b/db/knex_migrations/2025-10-15-0001-add-monitor-response-config.js index 370988b26..df8456455 100644 --- a/db/knex_migrations/2025-10-15-0001-add-monitor-response-config.js +++ b/db/knex_migrations/2025-10-15-0001-add-monitor-response-config.js @@ -1,7 +1,7 @@ exports.up = function (knex) { return knex.schema.alterTable("monitor", function (table) { table.boolean("save_response").notNullable().defaultTo(false); - table.boolean("save_error_response").notNullable().defaultTo(false); + table.boolean("save_error_response").notNullable().defaultTo(true); table.integer("response_max_length").defaultTo(10240); // Default 10KB }); }; diff --git a/src/pages/EditMonitor.vue b/src/pages/EditMonitor.vue index 51dfb4c6a..5ac12f725 100644 --- a/src/pages/EditMonitor.vue +++ b/src/pages/EditMonitor.vue @@ -1496,7 +1496,14 @@ -
+
-
+
-
+
@@ -2226,7 +2248,7 @@ const monitorDefaults = { maxredirects: 10, accepted_statuscodes: ["200-299"], saveResponse: false, - saveErrorResponse: false, + saveErrorResponse: true, responseMaxLength: 10240, dns_resolve_type: "A", dns_resolve_server: "1.1.1.1", diff --git a/test/e2e/specs/monitor-form.spec.js b/test/e2e/specs/monitor-form.spec.js index a886abcde..36d6eeff5 100644 --- a/test/e2e/specs/monitor-form.spec.js +++ b/test/e2e/specs/monitor-form.spec.js @@ -115,8 +115,11 @@ test.describe("Monitor Form", () => { await page.getByTestId("friendly-name-input").fill(friendlyName); await page.getByTestId("url-input").fill("https://www.example.com/"); + // Expect error response save enabled by default + await expect(page.getByLabel("Save HTTP Error Response for Notifications")).toBeChecked(); + await page.getByLabel("Save HTTP Success Response for Notifications").check(); - await page.getByLabel("Save HTTP Error Response for Notifications").check(); + await page.getByLabel("Save HTTP Error Response for Notifications").uncheck(); await page.getByLabel("Response Max Length (bytes)").fill("2048"); await screenshot(testInfo, page); @@ -127,7 +130,7 @@ test.describe("Monitor Form", () => { await page.waitForURL("/edit/*"); await expect(page.getByLabel("Save HTTP Success Response for Notifications")).toBeChecked(); - await expect(page.getByLabel("Save HTTP Error Response for Notifications")).toBeChecked(); + await expect(page.getByLabel("Save HTTP Error Response for Notifications")).toBeChecked({ checked: false }); await expect(page.getByLabel("Response Max Length (bytes)")).toHaveValue("2048"); await screenshot(testInfo, page);