From b6e8d548b0ca876ffe3d9b485d5358515746290f Mon Sep 17 00:00:00 2001 From: Anthony <70786+am17torres@users.noreply.github.com> Date: Tue, 23 Dec 2025 21:36:28 -0500 Subject: [PATCH] fix: update dns monitor to evaluate full response list on CAA resolver_type (#6520) --- server/monitor-types/dns.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/monitor-types/dns.js b/server/monitor-types/dns.js index 77032b302..1565ff1f2 100644 --- a/server/monitor-types/dns.js +++ b/server/monitor-types/dns.js @@ -50,8 +50,10 @@ class DnsMonitorType extends MonitorType { break; case "CAA": - dnsMessage = dnsRes[0].issue; - conditionsResult = handleConditions({ record: dnsRes[0].issue }); + // .filter(Boolean) was added because some CAA records do not contain an issue key, resulting in a blank list item. + // Hypothetical dnsRes [{ critical: 0, issuewild: 'letsencrypt.org' }, { critical: 0, issue: 'letsencrypt.org' }] + dnsMessage = `Records: ${dnsRes.map(record => record.issue).filter(Boolean).join(" | ")}`; + conditionsResult = dnsRes.some(record => handleConditions({ record: record.issue })); break; case "MX":