From e22784aaea49d0ed7cc3a589aa5927567183a517 Mon Sep 17 00:00:00 2001 From: mkdev11 Date: Tue, 6 Jan 2026 03:19:22 +0200 Subject: [PATCH] fix: guard against undefined conditions in MQTT monitor Add check for monitor.conditions before calling fromMonitor() to prevent JSON.parse(undefined) error when monitors don't have conditions defined. --- server/monitor-types/mqtt.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/monitor-types/mqtt.js b/server/monitor-types/mqtt.js index acc76e853..dd3863a89 100644 --- a/server/monitor-types/mqtt.js +++ b/server/monitor-types/mqtt.js @@ -35,8 +35,8 @@ class MqttMonitorType extends MonitorType { monitor.mqttCheckType = "keyword"; } - // Prepare conditions evaluation - const conditions = ConditionExpressionGroup.fromMonitor(monitor); + // Prepare conditions evaluation (only if monitor has conditions defined) + const conditions = monitor.conditions ? ConditionExpressionGroup.fromMonitor(monitor) : null; const hasConditions = conditions && conditions.children && conditions.children.length > 0; // Parse JSON if needed for conditions