From 951f1095122fe90a25eaa5afd1ef86fa2f719df9 Mon Sep 17 00:00:00 2001
From: Angel98518 <daniel98518@gmail.com>
Date: Tue, 6 Jan 2026 19:31:25 +0100
Subject: [PATCH] fix: add error logging to cloudflared socket handler empty
 catch blocks

Previously, errors in cloudflared socket handlers were silently swallowed
by empty catch blocks, making debugging difficult. This commit adds
proper error logging to all empty catch blocks in the cloudflared
socket handler to improve observability and debugging.

- Added error logging to join handler
- Added error logging to leave handler
- Added error logging to start handler
- Added error logging to removeToken handler
---
 .../cloudflared-socket-handler.js                | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/server/socket-handlers/cloudflared-socket-handler.js b/server/socket-handlers/cloudflared-socket-handler.js
index 809191fe8..5ebf529dd 100644
--- a/server/socket-handlers/cloudflared-socket-handler.js
+++ b/server/socket-handlers/cloudflared-socket-handler.js
@@ -41,14 +41,18 @@ module.exports.cloudflaredSocketHandler = (socket) => {
             io.to(socket.userID).emit(prefix + "installed", cloudflared.checkInstalled());
             io.to(socket.userID).emit(prefix + "running", cloudflared.running);
             io.to(socket.userID).emit(prefix + "token", await setting("cloudflaredTunnelToken"));
-        } catch (error) { }
+        } catch (error) {
+            log.error("cloudflared", "Error in join handler: " + error.message);
+        }
     });
 
     socket.on(prefix + "leave", async () => {
         try {
             checkLogin(socket);
             socket.leave("cloudflared");
-        } catch (error) { }
+        } catch (error) {
+            log.error("cloudflared", "Error in leave handler: " + error.message);
+        }
     });
 
     socket.on(prefix + "start", async (token) => {
@@ -61,7 +65,9 @@ module.exports.cloudflaredSocketHandler = (socket) => {
                 cloudflared.token = null;
             }
             cloudflared.start();
-        } catch (error) { }
+        } catch (error) {
+            log.error("cloudflared", "Error in start handler: " + error.message);
+        }
     });
 
     socket.on(prefix + "stop", async (currentPassword, callback) => {
@@ -84,7 +90,9 @@ module.exports.cloudflaredSocketHandler = (socket) => {
         try {
             checkLogin(socket);
             await setSetting("cloudflaredTunnelToken", "");
-        } catch (error) { }
+        } catch (error) {
+            log.error("cloudflared", "Error in removeToken handler: " + error.message);
+        }
     });
 
 };