From 224e6b8705ab91a4db083c3d1dee205fcfb50af1 Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Sat, 17 Jan 2026 14:28:36 +0100 Subject: [PATCH] Apply suggestions from code review --- .../2026-01-16-0000-add-screenshot-delay.js | 2 +- src/lang/en.json | 7 +++---- src/pages/EditMonitor.vue | 8 +++----- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/db/knex_migrations/2026-01-16-0000-add-screenshot-delay.js b/db/knex_migrations/2026-01-16-0000-add-screenshot-delay.js index 1e4e8a4c9..fa0829bdf 100644 --- a/db/knex_migrations/2026-01-16-0000-add-screenshot-delay.js +++ b/db/knex_migrations/2026-01-16-0000-add-screenshot-delay.js @@ -1,6 +1,6 @@ exports.up = function (knex) { return knex.schema.alterTable("monitor", function (table) { - table.integer("screenshot_delay").notNullable().defaultTo(0); + table.integer("screenshot_delay").notNullable().unsigned().defaultTo(0); }); }; diff --git a/src/lang/en.json b/src/lang/en.json index 35c499d8e..5462277dc 100644 --- a/src/lang/en.json +++ b/src/lang/en.json @@ -1055,10 +1055,9 @@ "remoteBrowserToggle": "By default Chromium runs inside the Uptime Kuma container. You can use a remote browser by toggling this switch.", "useRemoteBrowser": "Use a Remote Browser", "deleteRemoteBrowserMessage": "Are you sure want to delete this Remote Browser for all monitors?", - "Screenshot Delay ({ms})": "Screenshot Delay ({ms})", - "ms": "ms", - "screenshotDelayDescription": "Wait this many milliseconds before taking the screenshot.", - "screenshotDelayMaxInfo": "Maximum: {max}ms (0.5 × interval).", + "Screenshot Delay": "Screenshot Delay ({miliseconds})", + "miliseconds": "{n} milisecond | {n} miliseconds", + "screenshotDelayDescription": "Optionally wait this many milliseconds before taking the screenshot. Maximum: {maxValueMs}ms (0.5 × interval).", "screenshotDelayWarning": "Higher values keep the browser open longer, which may increase memory usage with many concurrent monitors.", "GrafanaOncallUrl": "Grafana Oncall URL", "systemService": "System Service", diff --git a/src/pages/EditMonitor.vue b/src/pages/EditMonitor.vue index 39b1f12b8..434441b34 100644 --- a/src/pages/EditMonitor.vue +++ b/src/pages/EditMonitor.vue @@ -266,7 +266,7 @@
- {{ $t("screenshotDelayDescription") }} - {{ - $t("screenshotDelayMaxInfo", { - max: Math.floor(monitor.interval * 1000 * 0.5), + {{ $t("screenshotDelayDescription", { + maxValueMs: Math.floor(monitor.interval * 1000 * 0.5), }) }}