Andrey/uptime-kuma
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): backoff all external TCP checks (#6613)

Browse Source 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Frank Elsinga 2026-01-06 18:43:54 +01:00 committed by GitHub
parent b1355c67f0
commit 11a2b8ed9b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 37 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
test/backend-test/monitors/test-tcp.js
View File

@ -5,6 +5,33 @@ const { UP, PENDING } = require("../../../src/util");
const net = require("net");
describe("TCP Monitor", () => {
/**
* Retries a test function with exponential backoff for external service reliability
* @param {Function} testFn - Async function to retry
* @param {object} heartbeat - Heartbeat object to reset between attempts
* @param {number} maxAttempts - Maximum number of retry attempts (default: 5)
* @returns {Promise<void>}
*/
async function retryExternalService(testFn, heartbeat, maxAttempts = 5) {
let lastError;
for (let attempt = 1; attempt <= maxAttempts; attempt++) {
try {
await testFn();
return; // Success, exit retry loop
} catch (error) {
lastError = error;
// Reset heartbeat for next attempt
heartbeat.msg = "";
heartbeat.status = PENDING;
// Wait a bit before retrying with exponential backoff
if (attempt < maxAttempts) {
await new Promise(resolve => setTimeout(resolve, 500 * 2 ** (attempt - 1)));
}
}
}
// If all retries failed, throw the last error
throw lastError;
}
/**
* Creates a TCP server on a specified port
* @param {number} port - The port number to listen on
@ -115,8 +142,9 @@ describe("TCP Monitor", () => {
status: PENDING,
};
await tcpMonitor.check(monitor, heartbeat, {});
await retryExternalService(async () => {
await tcpMonitor.check(monitor, heartbeat, {});
}, heartbeat);
assert.strictEqual(heartbeat.status, UP);
});
@ -138,8 +166,9 @@ describe("TCP Monitor", () => {
status: PENDING,
};
await tcpMonitor.check(monitor, heartbeat, {});
await retryExternalService(async () => {
await tcpMonitor.check(monitor, heartbeat, {});
}, heartbeat);
assert.strictEqual(heartbeat.status, UP);
});
@ -186,23 +215,9 @@ describe("TCP Monitor", () => {
status: PENDING,
};
// Retry up to 5 times for external service reliability
let lastError;
for (let attempt = 1; attempt <= 5; attempt++) {
try {
await tcpMonitor.check(monitor, heartbeat, {});
assert.strictEqual(heartbeat.status, UP);
return; // Success, exit test
} catch (error) {
lastError = error;
// Reset heartbeat for next attempt
heartbeat.msg = "";
heartbeat.status = PENDING;
// Wait a bit before retrying
await new Promise(resolve => setTimeout(resolve, 500 * 2 ** (attempt - 1)));
}
}
// If all retries failed, throw the last error
throw lastError;
await retryExternalService(async () => {
await tcpMonitor.check(monitor, heartbeat, {});
}, heartbeat);
assert.strictEqual(heartbeat.status, UP);
});
});